Skip to content

feat: add soundboard v14 #10843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

feat: add soundboard v14 #10843

merged 2 commits into from
Apr 25, 2025

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Adds soundboard for mainlib v14

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@sdanialraza sdanialraza added this to the discord.js 14.19 milestone Apr 23, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2025 8:36pm

Qjuh
Qjuh previously requested changes Apr 24, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Apr 24, 2025
@sdanialraza sdanialraza force-pushed the feat/add-soundboard-v14 branch from 6382ee7 to 4ea9e29 Compare April 25, 2025 16:14
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.52%. Comparing base (8702978) to head (a1c048d).
Report is 6 commits behind head on v14.

Additional details and impacted files 
@@            Coverage Diff             @@
##              v14   #10843      +/-   ##
==========================================
+ Coverage   35.51%   35.52%   +0.01%     
==========================================
  Files         228      228              
  Lines       14317    14321       +4     
  Branches     1255     1256       +1     
==========================================
+ Hits         5084     5088       +4     
  Misses       9189     9189              
  Partials       44       44
Flag Coverage Δ
proxy 66.27% <ø> (∅)
rest 88.04% <100.00%> (∅)
ws 36.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sdanialraza sdanialraza force-pushed the feat/add-soundboard-v14 branch from 4ea9e29 to 450811d Compare April 25, 2025 16:29
@sdanialraza sdanialraza force-pushed the feat/add-soundboard-v14 branch from 450811d to 09bed5f Compare April 25, 2025 16:36
@sdanialraza sdanialraza marked this pull request as ready for review April 25, 2025 16:39
@sdanialraza sdanialraza requested review from a team and iCrawl as code owners April 25, 2025 16:39
@sdanialraza sdanialraza requested review from ckohen, vladfrangu, kyranet, didinele, Jiralite and SpaceEEC and removed request for a team April 25, 2025 16:39
@sdanialraza sdanialraza requested a review from Qjuh April 25, 2025 16:40
vladfrangu
vladfrangu requested changes Apr 25, 2025
View reviewed changes
packages/discord.js/src/managers/GuildManager.js Outdated
* console.log(soundboardSounds.get('123456789012345678'));
*/
async fetchSoundboardSounds({ guildIds, time = 10_000 }) {
const shardCount = await this.client.options.shardCount;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right, it could be this.client.ws._ws.getShardCount or w/e

Qjuh
Qjuh requested changes Apr 25, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Apr 25, 2025
@vladfrangu vladfrangu merged commit d3154cf into v14 Apr 25, 2025
7 checks passed
@vladfrangu vladfrangu deleted the feat/add-soundboard-v14 branch April 25, 2025 20:37
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 25, 2025
@sdanialraza sdanialraza mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner

@ckohen ckohen Awaiting requested review from ckohen ckohen is a code owner automatically assigned from discordjs/rest

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/rest

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/rest

@Jiralite Jiralite Awaiting requested review from Jiralite Jiralite is a code owner automatically assigned from discordjs/rest

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
api support packages:discord.js packages:rest semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 14.19
Development

Successfully merging this pull request may close these issues.
3 participants
@sdanialraza @vladfrangu @Qjuh